Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbaBXSvj (ORCPT ); Mon, 24 Feb 2014 13:51:39 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:26962 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbaBXSvi (ORCPT ); Mon, 24 Feb 2014 13:51:38 -0500 X-IronPort-AV: E=Sophos;i="4.97,536,1389744000"; d="scan'208";a="103637010" Message-ID: <530B94B7.5080602@citrix.com> Date: Mon, 24 Feb 2014 18:51:35 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20121215 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Paul Bolle CC: Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michael Opdenacker , , , , Richard Weinberger Subject: Re: [Xen-devel] [PATCH v2] xen: remove XEN_PRIVILEGED_GUEST References: <201402171223.s1HCNG0S023567@userz7022.oracle.com> <1392642197.13000.20.camel@x220> <20140217144307.GB28658@localhost.localdomain> <1392718467.30073.12.camel@x220> <1392728861.5144.10.camel@x220> In-Reply-To: <1392728861.5144.10.camel@x220> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.2.76] X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/14 13:07, Paul Bolle wrote: > This patch removes the Kconfig symbol XEN_PRIVILEGED_GUEST which is > used nowhere in the tree. > > We do know grub2 has a script that greps kernel configuration files for > its macro. It shouldn't do that. As Linus summarized: > This is a grub bug. It really is that simple. Treat it as one. > > Besides, grub2's grepping for that macro is actually superfluous. See, > that script currently contains this test (simplified): > grep -x CONFIG_XEN_DOM0=y $config || grep -x CONFIG_XEN_PRIVILEGED_GUEST=y $config > > But since XEN_DOM0 and XEN_PRIVILEGED_GUEST are by definition equal, > removing XEN_PRIVILEGED_GUEST cannot influence this test. > > So there's no reason to not remove this symbol, like we do with all > unused Kconfig symbols. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/