Date: Mon, 24 Feb 2014 11:59:07 -0700
From: Jonathan Corbet <corbet@lwn.net>
To: Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH for-next 3/4] epoll: struct epoll support
Message-ID: <20140224115907.07092911@lwn.net>
In-Reply-To: <1393206162-18151-4-git-send-email-n1ght.4nd.d4y@gmail.com>
References: <1393206162-18151-1-git-send-email-n1ght.4nd.d4y@gmail.com>
	<1393206162-18151-4-git-send-email-n1ght.4nd.d4y@gmail.com>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

So I was just looking things over quickly, and something jumped out at
me.  In ep_control():

> +	} else if (!(*io) && epi) {
> +		/* delete this eventpoll entry */
> +		if (is_file_epoll(target)) {
> +			tep = target->private_data;
> +			mutex_lock_nested(&tep->mtx, 1);
> +		}
> +		if (is_file_epoll(target))
> +			mutex_lock_nested(&tep->mtx, 1);

How could that possibly work?  I can't imagine tep->mtx is going to
react well to being locked a second time...

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/