Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbaBXVie (ORCPT ); Mon, 24 Feb 2014 16:38:34 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:38814 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751864AbaBXVic (ORCPT ); Mon, 24 Feb 2014 16:38:32 -0500 MIME-Version: 1.0 In-Reply-To: <21860356.103351393198399120.JavaMail.weblogic@epml01> References: <21860356.103351393198399120.JavaMail.weblogic@epml01> From: Bjorn Helgaas Date: Mon, 24 Feb 2014 14:38:11 -0700 Message-ID: Subject: Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse To: Jingoo Han Cc: Thomas Gleixner , LKML , Ingo Molnar , Peter Zijlstra , Mohit Kumar , pci Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han wrote: > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: >> >> There is no reason to care about irq_desc in that context, escpecially >> as irq_data for that interrupt is retrieved as well. >> >> Use the proper accessor for the msi descriptor >> >> Signed-off-by: Thomas Gleixner >> Cc: Bjorn Helgaas >> Cc: Jingoo Han >> Cc: Mohit Kumar >> Cc: pci > > Acked-by: Jingoo Han Acked-by: Bjorn Helgaas Thomas, I assume you'll merge this along with the rest of your series. I don't have any pending changes in this area. Bjorn > A few days ago, I noticed that irq_data_get_msi() can be used. > However, I did not submit the same patch. I really appreciate > your patch. :-) > > Best regards, > Jingoo Han > >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> Index: tip/drivers/pci/host/pcie-designware.c >> =================================================================== >> --- tip.orig/drivers/pci/host/pcie-designware.c >> +++ tip/drivers/pci/host/pcie-designware.c >> @@ -294,14 +294,12 @@ no_valid_irq: >> static void clear_irq(unsigned int irq) >> { >> unsigned int pos, nvec; >> - struct irq_desc *desc; >> struct msi_desc *msi; >> struct pcie_port *pp; >> struct irq_data *data = irq_get_irq_data(irq); >> >> /* get the port structure */ >> - desc = irq_to_desc(irq); >> - msi = irq_desc_get_msi_desc(desc); >> + msi = irq_data_get_msi(data); >> pp = sys_to_pcie(msi->dev->bus->sysdata); >> if (!pp) { >> BUG(); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/