Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbaBXXSz (ORCPT ); Mon, 24 Feb 2014 18:18:55 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:52183 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752998AbaBXXSx (ORCPT ); Mon, 24 Feb 2014 18:18:53 -0500 From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: Linux PM list , ACPI Devel Maling List , Linux Kernel Mailing List , Linux PCI , Alan Stern Subject: Re: [PATCH 2/2] PCI / PM: Resume runtime-suspended devices later during system suspend Date: Tue, 25 Feb 2014 00:33:51 +0100 Message-ID: <1759353.q92oO0bmJQ@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.13.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1853950.oxM3KDpyLu@vostro.rjw.lan> <3851541.s2776YTCMH@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, February 24, 2014 01:58:05 PM Bjorn Helgaas wrote: > On Sun, Feb 23, 2014 at 4:21 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Runtime-suspended devices are resumed during system suspend by > > pci_pm_prepare() for two reasons: First, because they may need > > to be reprogrammed in order to change their wakeup settings and, > > second, because they may need to be operatonal for their children > > to be successfully suspended. That is a problem, though, if there > > are many runtime-suspended devices that need to be resumed this > > way during system suspend, because the .prepare() PM callbacks of > > devices are executed sequentially and the times taken by them > > accumulate, which may increase the total system suspend time quite > > a bit. > > > > For this reason, move the resume of runtime-suspended devices up > > to the next phase of device suspend (during system suspend), except > > for the ones that have power.ignore_children set. The exception is > > made, because the devices with power.ignore_children set may still > > be necessary for their children to be successfully suspended (during > > system suspend) and they won't be resumed automatically as a result > > of the runtime resume of their children. > > > > Signed-off-by: Rafael J. Wysocki > > Acked-by: Bjorn Helgaas > > You can merge these two via your tree if you want. I don't have any > changes queued up for pci-driver.c. I will, thanks! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/