From: Peter Chen <Peter.Chen@freescale.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
        Courtney Cavin <courtney.cavin@sonymobile.com>
CC: "richard.zhao@freescale.com" <richard.zhao@freescale.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "Kumar Gala" <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        David Brown <davidb@codeaurora.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] usb: chipidea: msm: Add device tree binding
 information
Thread-Topic: [PATCH v2 1/3] usb: chipidea: msm: Add device tree binding
 information
Thread-Index: AQHPMUnzTozOKQ0uAUSwvbpPBeKycZrFM4jw
Date: Tue, 25 Feb 2014 01:57:24 +0000
Message-ID: <2d4d3fed4d9e405fb4c0b7a8a34e9222@BL2PR03MB226.namprd03.prod.outlook.com>
References: <1392729681-21022-1-git-send-email-iivanov@mm-sol.com>
	 <1392729681-21022-2-git-send-email-iivanov@mm-sol.com>
	 <20140218212659.GL1706@sonymobile.com>
	 <1392824602.17130.68.camel@iivanov-dev>
	 <20140219174655.GN1706@sonymobile.com>
 <1393237096.6481.12.camel@iivanov-dev>
In-Reply-To: <1393237096.6481.12.camel@iivanov-dev>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org

 
> 
> Hi,
> 
> On Wed, 2014-02-19 at 09:46 -0800, Courtney Cavin wrote:
> > On Wed, Feb 19, 2014 at 04:43:22PM +0100, Ivan T. Ivanov wrote:
> > >
> > > Hi,
> > >
> > > On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote:
> > > > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote:
> > > > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> > > > >
> > > > > Document device tree binding information as required by the
> > > > > Qualcomm USB controller.
> > > > >
> > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > > > > ---
> > > > >  .../devicetree/bindings/usb/msm-hsusb.txt          |   17
> +++++++++++++++++
> > > >
> > > > Although you mentioned to Josh that this is intended for "non-
> standard"
> > > > Chipidea properties, I don't see any other than requiring that
> 'dr_mode'
> > > > must be "peripheral".  It would seem that this should all be
> > > > integrated into a ci3xxx.txt.
> > >
> > > Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt.
> > > So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt?
> >
> > Sorry, I was referring to ci13xxx-imx.txt, which was apparently moved
> > to ci-hdrc-imx.txt.  I was recommending to merge the two into one
> > 'ci13xxx.txt', as this binding seems to be a new compatible for the
> > same basic chip.  Now perhaps 'ci-hdrc.txt'.
> >
> > Although I agree with Josh that this name should be changed, and I
> > think either of your two suggestions would be acceptable, I would like
> > to at least discuss the possibility of actually merging the two in
> > this series.
> >
> > Comments?
> 
> 
> iMX version have required and recommender properties which are not
> meaningful for QCOM variant. I will prefer separate file. It depends on
> Freescale engineers (now in Cc:)
> 
> 

Unlike dwc3, there is no common dts entry for chipidea core, every platform
uses its own dts to cover both common and platform-specific properties.

I also have plan to use dwc3 style way for dts, but msm platform has still
not used dts, I don't know how many msm platforms need to change, once
you finish transferring msm to dts, I will split common and platform specific
entry.

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/