Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbaBYCtF (ORCPT ); Mon, 24 Feb 2014 21:49:05 -0500 Received: from mga02.intel.com ([134.134.136.20]:42026 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbaBYCtD (ORCPT ); Mon, 24 Feb 2014 21:49:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,538,1389772800"; d="scan'208";a="489216075" From: "David E. Box" To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Cc: "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com, jacob.jun.pan@intel.com Subject: [PATCH V2 1/2] x86: IOSF: add dummy functions for loadable modules Date: Mon, 24 Feb 2014 18:47:21 -0800 Message-Id: <1393296442-12942-2-git-send-email-david.e.box@linux.intel.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1393296442-12942-1-git-send-email-david.e.box@linux.intel.com> References: <1393296442-12942-1-git-send-email-david.e.box@linux.intel.com> In-Reply-To: <1393117352-23717-1-git-send-email-david.e.box@linux.intel.com> References: <1393117352-23717-1-git-send-email-david.e.box@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "David E. Box" Some loadable modules only need IOSF access on the platforms where it exists. Provide dummy functions to allow these modules to compile and load on the platforms where it doesn't exist. Signed-off-by: David E. Box --- arch/x86/include/asm/iosf_mbi.h | 39 ++++++++++++++++++++++++++++++++++++--- arch/x86/kernel/iosf_mbi.c | 6 ++++++ 2 files changed, 42 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/iosf_mbi.h b/arch/x86/include/asm/iosf_mbi.h index 8e71c79..6dcaa1d 100644 --- a/arch/x86/include/asm/iosf_mbi.h +++ b/arch/x86/include/asm/iosf_mbi.h @@ -5,6 +5,8 @@ #ifndef IOSF_MBI_SYMS_H #define IOSF_MBI_SYMS_H +#ifdef CONFIG_IOSF_MBI + #define MBI_MCR_OFFSET 0xD0 #define MBI_MDR_OFFSET 0xD4 #define MBI_MCRX_OFFSET 0xD8 @@ -50,6 +52,8 @@ #define BT_MBI_PCIE_READ 0x00 #define BT_MBI_PCIE_WRITE 0x01 +extern bool iosf_mbi_available(void); + /** * iosf_mbi_read() - MailBox Interface read command * @port: port indicating subunit being accessed @@ -60,7 +64,7 @@ * Locking is handled by spinlock - cannot sleep. * Return: Nonzero on error */ -int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr); +extern int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr); /** * iosf_mbi_write() - MailBox unmasked write command @@ -72,7 +76,7 @@ int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr); * Locking is handled by spinlock - cannot sleep. * Return: Nonzero on error */ -int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr); +extern int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr); /** * iosf_mbi_modify() - MailBox masked write command @@ -85,6 +89,35 @@ int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr); * Locking is handled by spinlock - cannot sleep. * Return: Nonzero on error */ -int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask); +extern int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask); + +#else /* CONFIG_IOSF_MBI is not enabled */ +static inline +bool iosf_mbi_available(void) +{ + return false; +} + +static inline +int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr) +{ + WARN(); + return -EPERM; +} + +static inline +int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr) +{ + WARN(); + return -EPERM; +} + +static inline +int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask) +{ + WARN(); + return -EPERM; +} +#endif /* CONFIG_IOSF_MBI */ #endif /* IOSF_MBI_SYMS_H */ diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c index c3aae66..d3803c6 100644 --- a/arch/x86/kernel/iosf_mbi.c +++ b/arch/x86/kernel/iosf_mbi.c @@ -177,6 +177,12 @@ int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask) } EXPORT_SYMBOL(iosf_mbi_modify); +bool iosf_mbi_available(void) +{ + return mbi_pdev; +} +EXPORT_SYMBOL(iosf_mbi_available); + static int iosf_mbi_probe(struct pci_dev *pdev, const struct pci_device_id *unused) { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/