Date: Tue, 25 Feb 2014 05:25:31 +0000 (GMT)
From: Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH V8 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver
To: kishon@ti.com, yuvaraj.cd@samsung.com
Cc: kgene.kim@samsung.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org, grant.likely@linaro.org, robh+dt@kernel.org,
        swarren@wwwdotorg.org, mark.rutland@arm.com, yuvaraj.cd@gmail.com,
        ks.giri@samsung.com, vasanth.a@samsung.com,
        Jingoo Han <jg1.han@samsung.com>
Reply-to: jg1.han@samsung.com
MIME-version: 1.0
Msgkey: 20140225051516731@jg1.han
Content-type: text/plain; charset=euc-kr
MIME-version: 1.0
Message-id: <10341096.99771393305930937.JavaMail.weblogic@epml25>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit

On Mon, 24 Feb 2014 19:26:44, Kishon Vijay Abraham I wrote: 
> On Monday 24 February 2014 07:02 PM, Yuvaraj Kumar C D wrote:
> > This patch adds the SATA PHY driver for Exynos5250.Exynos5250 SATA
> > PHY comprises of CMU and TRSV blocks which are of I2C register Map.
> > So this patch also adds a i2c client driver, which is used configure
> 
> We no longer have i2c client driver here.

Right.

> > the CMU and TRSV block of exynos5250 SATA PHY.
> > 
> > This patch incorporates the generic PHY framework to deal with SATA
> > PHY.
> 
> It should be rephrased to have *uses* generic PHY framework. However I feel we
> can do away with this line.

Right, "incorporates" is confusing.

> > 
> > This patch depends on the below patch for the sata functionality
> > 	[1].ata: ahci_platform: Manage SATA PHY
> > 		by Roger Quadros <rogerq@xxxxxx>
> 
> hasn't this patch merged yet?

Currently, this patch was queued into libata tree, for-next. [1]

[1] http://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-next&id=21b5faeec229d4f70a7f60a7b0b065c98198f491

Best regards,
Jingoo Han????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?