Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbaBYQHT (ORCPT ); Tue, 25 Feb 2014 11:07:19 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:62634 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbaBYQHO (ORCPT ); Tue, 25 Feb 2014 11:07:14 -0500 MIME-Version: 1.0 In-Reply-To: <20140221110637.GG7541@e106331-lin.cambridge.arm.com> References: <1392943090-30556-1-git-send-email-bjorn.andersson@sonymobile.com> <1392943090-30556-3-git-send-email-bjorn.andersson@sonymobile.com> <20140221110637.GG7541@e106331-lin.cambridge.arm.com> Date: Tue, 25 Feb 2014 08:07:13 -0800 Message-ID: Subject: Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller From: Bjorn Andersson To: Mark Rutland Cc: Bjorn Andersson , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Rob Landley , Wolfram Sang , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Andy Gross , Stephen Boyd , "Ivan T. Ivanov" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2014 at 3:06 AM, Mark Rutland wrote: > On Fri, Feb 21, 2014 at 12:38:10AM +0000, Bjorn Andersson wrote: [...] > >> +static const struct of_device_id qup_i2c_dt_match[] = { >> + { .compatible = "qcom,i2c-qup-v1.1.1" }, >> + { .compatible = "qcom,i2c-qup-v2.1.1" }, >> + { .compatible = "qcom,i2c-qup-v2.2.1" }, > > The all seem to be handled the same. > > Are they all compatible with the "qcom,i2c-qup-v1.1.1" programming > model, such that it could be used as a fallback in the compatible list > (and the driver would only need to look for it for now)? The v2 model will get BAM (DMAEngine) support soon, v1 uses an older DMA core. So there's a difference. I'm not aware what differences there are between 2.1.1 and 2.2.1. Question is if next change will be called v3, as we then could skip the reset of the version. We could probably skip 2.1.1 as that's supposed to be the first revision of 8x74, with all the expected HW quirks...I.e. not sure if anyone should use that. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/