Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198AbaBYRTw (ORCPT ); Tue, 25 Feb 2014 12:19:52 -0500 Received: from merlin.infradead.org ([205.233.59.134]:47827 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbaBYRTv (ORCPT ); Tue, 25 Feb 2014 12:19:51 -0500 Date: Tue, 25 Feb 2014 18:19:40 +0100 From: Peter Zijlstra To: Johannes Weiner Cc: Alexander Graf , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rik van Riel , Mel Gorman , Andrew Morton , Ingo Molnar , Hugh Dickins , Izik Eidus , Andrea Arcangeli Subject: Re: [PATCH] ksm: Expose configuration via sysctl Message-ID: <20140225171940.GS6835@laptop.programming.kicks-ass.net> References: <1393284484-27637-1-git-send-email-agraf@suse.de> <20140225171528.GJ4407@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140225171528.GJ4407@cmpxchg.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2014 at 12:15:28PM -0500, Johannes Weiner wrote: > On Tue, Feb 25, 2014 at 12:28:04AM +0100, Alexander Graf wrote: > > Configuration of tunables and Linux virtual memory settings has traditionally > > happened via sysctl. Thanks to that there are well established ways to make > > sysctl configuration bits persistent (sysctl.conf). > > > > KSM introduced a sysfs based configuration path which is not covered by user > > space persistent configuration frameworks. > > > > In order to make life easy for sysadmins, this patch adds all access to all > > KSM tunables via sysctl as well. That way sysctl.conf works for KSM as well, > > giving us a streamlined way to make KSM configuration persistent. > > > > Reported-by: Sasche Peilicke > > Signed-off-by: Alexander Graf > > --- > > kernel/sysctl.c | 10 +++++++ > > mm/ksm.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 88 insertions(+), 0 deletions(-) > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > index 332cefc..2169a00 100644 > > --- a/kernel/sysctl.c > > +++ b/kernel/sysctl.c > > @@ -217,6 +217,9 @@ extern struct ctl_table random_table[]; > > #ifdef CONFIG_EPOLL > > extern struct ctl_table epoll_table[]; > > #endif > > +#ifdef CONFIG_KSM > > +extern struct ctl_table ksm_table[]; > > +#endif > > > > #ifdef HAVE_ARCH_PICK_MMAP_LAYOUT > > int sysctl_legacy_va_layout; > > @@ -1279,6 +1282,13 @@ static struct ctl_table vm_table[] = { > > }, > > > > #endif /* CONFIG_COMPACTION */ > > +#ifdef CONFIG_KSM > > + { > > + .procname = "ksm", > > + .mode = 0555, > > + .child = ksm_table, > > + }, > > +#endif > > ksm can be a module, so this won't work. > > Can we make those controls proper module parameters instead? You can do dynamic sysctl registration and removal. Its its own little filesystem of sorts. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/