Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753101AbaBYVud (ORCPT ); Tue, 25 Feb 2014 16:50:33 -0500 Received: from mail-oa0-f43.google.com ([209.85.219.43]:43212 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbaBYVu3 (ORCPT ); Tue, 25 Feb 2014 16:50:29 -0500 Message-ID: <530D1021.1050402@acm.org> Date: Tue, 25 Feb 2014 15:50:25 -0600 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Jiri Slaby CC: jirislaby@gmail.com, linux-kernel@vger.kernel.org, Tomas Cech , openipmi-developer@lists.sourceforge.net, Rocky Craig Subject: Re: [PATCH 1/1] Char: ipmi_bt_sm, fix infinite loop References: <1393323294-11423-1-git-send-email-jslaby@suse.cz> In-Reply-To: <1393323294-11423-1-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks right to me. Rocky, copying you in case there's an issue with this. Thanks, -corey On 02/25/2014 04:14 AM, Jiri Slaby wrote: > In read_all_bytes, we do > unsigned char i; > ... > bt->read_data[0] = BMC2HOST; > bt->read_count = bt->read_data[0]; > ... > for (i = 1; i <= bt->read_count; i++) > bt->read_data[i] = BMC2HOST; > > If bt->read_data[0] == bt->read_count == 255, we loop infinitely in > the 'for' loop. Make 'i' an 'int' instead of 'char' to get rid of the > overflow and finish the loop after 255 iterations every time. > > Signed-off-by: Jiri Slaby > Reported-and-debugged-by: Rui Hui Dian > Cc: Tomas Cech > Cc: Corey Minyard > Cc: > --- > drivers/char/ipmi/ipmi_bt_sm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c > index f5e4cd7617f6..61e71616689b 100644 > --- a/drivers/char/ipmi/ipmi_bt_sm.c > +++ b/drivers/char/ipmi/ipmi_bt_sm.c > @@ -352,7 +352,7 @@ static inline void write_all_bytes(struct si_sm_data *bt) > > static inline int read_all_bytes(struct si_sm_data *bt) > { > - unsigned char i; > + unsigned int i; > > /* > * length is "framing info", minimum = 4: NetFn, Seq, Cmd, cCode. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/