Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbaBYWUI (ORCPT ); Tue, 25 Feb 2014 17:20:08 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:48738 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbaBYWUF (ORCPT ); Tue, 25 Feb 2014 17:20:05 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 26 Feb 2014 00:20:04 +0200 Message-ID: Subject: Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP From: Or Gerlitz To: Jiri Kosina Cc: Roland Dreier , Amir Vadai , Eli Cohen , Or Gerlitz , Eugenia Emantayev , "David S. Miller" , Mel Gorman , "netdev@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2014 at 12:11 AM, Jiri Kosina wrote: > On Tue, 25 Feb 2014, Or Gerlitz wrote: >> And what happens if you use IPoIB datagram mode, is/why the patch is >> needed there? > I admittedly am no infiniband expert, but my understanding is that in > principle Connected/Datagram mode is about MTU and checksum offloading, yes, the differences between the mode relate to these aspects, however > but the TX path is the same. Please correct me if I am wrong. no, note that your patch only touched drivers/infiniband/ulp/ipoib/ipoib_cm.c which is basically compiled out if you set CONFIG_INFINIBAND_IPOIB_CM, so surely the TX path for the datagram vs. connected modes are different. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/