Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661AbaBYXEE (ORCPT ); Tue, 25 Feb 2014 18:04:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18780 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753326AbaBYXEB (ORCPT ); Tue, 25 Feb 2014 18:04:01 -0500 Message-ID: <530D2141.50707@redhat.com> Date: Tue, 25 Feb 2014 18:03:29 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Alex Thorlton , linux-kernel@vger.kernel.org CC: Gerald Schaefer , Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Andrew Morton , Paolo Bonzini , "Kirill A. Shutemov" , Mel Gorman , Ingo Molnar , Peter Zijlstra , Andrea Arcangeli , Oleg Nesterov , "Eric W. Biederman" , Alexander Viro , linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org Subject: Re: [PATCH 3/3] exec: kill the unnecessary mm->def_flags setting in load_elf_binary() References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2014 03:54 PM, Alex Thorlton wrote: > load_elf_binary() sets current->mm->def_flags = def_flags and > def_flags is always zero. Not only this looks strange, this is > unnecessary because mm_init() has already set ->def_flags = 0. > > Signed-off-by: Alex Thorlton > Suggested-by: Oleg Nesterov Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/