Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751921AbaBZDsl (ORCPT ); Tue, 25 Feb 2014 22:48:41 -0500 Received: from ozlabs.org ([203.10.76.45]:55976 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbaBZDsk (ORCPT ); Tue, 25 Feb 2014 22:48:40 -0500 Message-ID: <1393386516.29388.6.camel@concordia> Subject: Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters From: Michael Ellerman To: Cody P Schafer Cc: Linux PPC , "Aneesh Kumar K.V" , Anshuman Khandual , Anton Blanchard , Benjamin Herrenschmidt , Kumar Gala , Lijun Pan , Li Yang , Paul Bolle , Priyanka Jain , Scott Wood , Tang Yuantian , LKML , Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo , Ingo Molnar Date: Wed, 26 Feb 2014 14:48:36 +1100 In-Reply-To: <530D0BA1.90609@linux.vnet.ibm.com> References: <20140225033330.54F332C02FB@ozlabs.org> <530D0BA1.90609@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-02-25 at 13:31 -0800, Cody P Schafer wrote: > On 02/24/2014 07:33 PM, Michael Ellerman wrote: > > On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: > >> Signed-off-by: Cody P Schafer > >> --- > >> arch/powerpc/perf/Makefile | 2 ++ > >> arch/powerpc/platforms/Kconfig.cputype | 6 ++++++ > >> 2 files changed, 8 insertions(+) > >> > >> diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile > >> index 60d71ee..f9c083a 100644 > >> --- a/arch/powerpc/perf/Makefile > >> +++ b/arch/powerpc/perf/Makefile > >> @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o > >> obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o > >> obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o > >> > >> +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o > >> + > >> obj-$(CONFIG_PPC64) += $(obj64-y) > >> obj-$(CONFIG_PPC32) += $(obj32-y) > >> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype > >> index 434fda3..dcc67cd 100644 > >> --- a/arch/powerpc/platforms/Kconfig.cputype > >> +++ b/arch/powerpc/platforms/Kconfig.cputype > >> @@ -364,6 +364,12 @@ config PPC_PERF_CTRS > >> help > >> This enables the powerpc-specific perf_event back-end. > >> > >> +config HV_PERF_CTRS > >> + def_bool y > > > > This was bool, why did you change it? > > No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518 > Maybe you're confusing v2.1 and v2 of this patch? Er yes. Point releases of a patch series confuse me :) > >> + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT > > > > Should be: > > > > depends on PERF_EVENTS && PPC_PSERIES > > > >> + help > >> + Enable access to perf counters provided by the hypervisor > >> + > > Yep, the v2.1 patch (which I bungled and labeled as 9/11) already > changes both of these. > It'll end up rolled into v3. Yes please. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/