Message-ID: <530DB6FE.9020307@hitachi.com>
Date: Wed, 26 Feb 2014 18:42:22 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Organization: Hitachi, Ltd., Japan
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Hemant Kumar <hkshaw@linux.vnet.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>, linux-kernel@vger.kernel.org,
        srikar@linux.vnet.ibm.com, peterz@infradead.org, oleg@redhat.com,
        hegdevasant@linux.vnet.ibm.com, mingo@redhat.com, anton@redhat.com,
        systemtap@sourceware.org, aravinda@linux.vnet.ibm.com, penberg@iki.fi
Subject: Re: Re: [RFC PATCH v1 0/2] perf: Support for SDT markers
References: <20140224090833.7998.5416.stgit@hemant-fedora> <530C821D.7000704@hitachi.com> <530CBD53.9010605@linux.vnet.ibm.com> <87ha7muw14.fsf@sejong.aot.lge.com> <530DADEB.4090709@linux.vnet.ibm.com>
In-Reply-To: <530DADEB.4090709@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

(2014/02/26 18:03), Hemant Kumar wrote:
> On 02/26/2014 01:48 PM, Namhyung Kim wrote:
>> Hi Masami and Hemant,
>>
>> On Tue, 25 Feb 2014 21:27:07 +0530, Hemant Kumar wrote:
>>> On 02/25/2014 05:14 PM, Masami Hiramatsu wrote:
>>>> (2014/02/24 18:14), Hemant Kumar wrote:
>>>>> First, scan the binaries using :
>>>>> # perf list sdt --scan
>>>>>
>>>>> Creating a cache of SDT markers...
>>>>> perf sdt cache created!
>>>>>    Use : "perf list sdt"
>>>>>    to see the SDT markers
>>>> Hmm, in that case, I think you'd better introduce perf-sdt for scanning.
>>>> e.g.
>>>>
>>>>    # perf sdt --scan app
>>> Hmm, this seems a better idea :)
>>>
>>>>    then you can add app to sdt cache, without app,
>>>>
>>>>    # perf sdt --scan
>>>>
>>>>    will just scans all binaries on the PATH and the libraries which listed
>>>> by `ldconfig --print-caceh`
>> What should be done with the new perf sdt command?  If it's only
>> intended to list the markers, I'd just suggest to add "perf list sdt" as
>> this patch did.

No, here what I said is, the "perf sdt" is only for managing SDT cache
as like as "perf buildid-cache". Thus, "perf sdt-cache" might be better.

BTW, the SDT markers can be changed if the application is updated.
To ensure the correctness of SDT markers, we should store buildid in the
cache file and check it when listing and using them.

> If we display the SDT markers along with the other events in perf list, 
> then I think we can go with
> perf list sdt. I am not too sure though! :)
> 
> For me, the main issue was that the markers are not events. They become 
> events after
> we place them in the uprobe_events file just like functions.  But we use 
> `perf list` to
> display all the "events" available on a system. Isn't it?

As I said, if perf accepts -e "%app:sdt" option, showing SDT events as
fixed events does not matter, since it is transparent to users. :)

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/