Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbaBZRHA (ORCPT ); Wed, 26 Feb 2014 12:07:00 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:42633 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbaBZRG6 (ORCPT ); Wed, 26 Feb 2014 12:06:58 -0500 Date: Wed, 26 Feb 2014 11:06:56 -0600 From: Andy Gross To: Stanimir Varbanov Cc: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver Message-ID: <20140226170656.GA21772@qualcomm.com> References: <1393283500-18599-1-git-send-email-agross@codeaurora.org> <1393283500-18599-3-git-send-email-agross@codeaurora.org> <530E1BAB.6040609@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <530E1BAB.6040609@mm-sol.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote: > > + /* read revision and configuration information */ > > + val = readl_relaxed(bdev->regs + BAM_REVISION) & NUM_EES_MASK; > > + > > The ees shit is not zero and you got wrong ee. Could you add the line > below or something similar: > > val = (val >> NUM_EES_SHIFT) & NUM_EES_MASK; > Good catch. I missed the shift when I reworked and got lucky that the revision is in the lower 8 bits and is non-zero. -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/