Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990AbaBZWQ7 (ORCPT ); Wed, 26 Feb 2014 17:16:59 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:53806 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbaBZWQ5 (ORCPT ); Wed, 26 Feb 2014 17:16:57 -0500 Date: Wed, 26 Feb 2014 14:16:51 -0800 From: josh@joshtriplett.org To: "Rafael J. Wysocki" Cc: Rashika Kheria , linux-kernel@vger.kernel.org, Viresh Kumar , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c Message-ID: <20140226221651.GA24021@cloud> References: <20140226154625.GA10701@rashika> <1393432962-3647-1-git-send-email-rashika.kheria@gmail.com> <16591432.HQVTHU5NYJ@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16591432.HQVTHU5NYJ@vostro.rjw.lan> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2014 at 10:56:45PM +0100, Rafael J. Wysocki wrote: > On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote: > > Mark function as static in cpufreq.c because it is not > > used outside this file. > > > > This eliminates the following warning in cpufreq.c: > > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > v2 has been Reviewed-by: Josh already, right? Feel free to forward-propagate to v3 as well, if that helps. > > --- > > Changes since v1: > > Incorrect Fix > > Changes since v2: > > Show Changelog > > > > drivers/cpufreq/cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 08ca8c9..54fd670 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition); > > /********************************************************************* > > * SYSFS INTERFACE * > > *********************************************************************/ > > -ssize_t show_boost(struct kobject *kobj, > > +static ssize_t show_boost(struct kobject *kobj, > > struct attribute *attr, char *buf) > > { > > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled); > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/