Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbaB0AFn (ORCPT ); Wed, 26 Feb 2014 19:05:43 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:52763 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbaB0AFl (ORCPT ); Wed, 26 Feb 2014 19:05:41 -0500 Message-ID: <530E8154.9060403@codeaurora.org> Date: Wed, 26 Feb 2014 16:05:40 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Josh Cartwright CC: Dmitry Torokhov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs References: <1393441562-685-1-git-send-email-sboyd@codeaurora.org> <1393441562-685-2-git-send-email-sboyd@codeaurora.org> <20140226235959.GD18563@joshc.qualcomm.com> In-Reply-To: <20140226235959.GD18563@joshc.qualcomm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/14 15:59, Josh Cartwright wrote: > On Wed, Feb 26, 2014 at 11:05:54AM -0800, Stephen Boyd wrote: >> Use the regmap APIs for this driver instead of custom pm8xxx >> APIs. This breaks this driver's dependency on the pm8xxx APIs and >> allows us to easily port it to other bus protocols in the future. >> >> Signed-off-by: Stephen Boyd >> --- >> drivers/input/misc/pmic8xxx-pwrkey.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c >> index 0e1a05f95858..cf6125dc3b51 100644 >> --- a/drivers/input/misc/pmic8xxx-pwrkey.c >> +++ b/drivers/input/misc/pmic8xxx-pwrkey.c >> @@ -120,6 +120,10 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev) >> return -ENOMEM; >> } >> >> + regmap = dev_get_regmap(pdev->dev.parent, NULL); >> + if (!regmap) >> + return -ENODEV; >> + > This looks really weird. A previous version of patch was included in > v3.14-rc1 (1e63bd9cc4), which already included a very similar hunk... > > Maybe the fact that the hunk isn't identical is why a rebase didn't drop > it (and instead, now if this gets merged, we'll have unnecessary > duplication). > Ah yeah, sorry about that. This patch should just be ignored. I don't think it affects anything else in the series? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/