Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbaB0MpN (ORCPT ); Thu, 27 Feb 2014 07:45:13 -0500 Received: from mail-ee0-f49.google.com ([74.125.83.49]:44767 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbaB0MpH (ORCPT ); Thu, 27 Feb 2014 07:45:07 -0500 Date: Thu, 27 Feb 2014 13:45:01 +0100 From: Ingo Molnar To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Cody P Schafer , Corey Ashford , David Ahern , Frederic Weisbecker , Jean Pihet , Mike Galbraith , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Stephane Eranian , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL 00/12] perf/core improvements and fixes Message-ID: <20140227124501.GA11916@gmail.com> References: <1393271800-17505-1-git-send-email-acme@infradead.org> <20140227114658.GA26449@gmail.com> <20140227120227.GC9614@krava.brq.redhat.com> <20140227123052.GA11475@gmail.com> <20140227124047.GF9614@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140227124047.GF9614@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jiri Olsa wrote: > On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote: > > > > * Jiri Olsa wrote: > > > > > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: > > > > > > > > * Arnaldo Carvalho de Melo wrote: > > > > > > > > > From: Arnaldo Carvalho de Melo > > > > > > > SNIP > > > > > Pulled, thanks a lot Arnaldo! > > > > > > > > Btw., the build output looks weird now - on a system that used to pass > > > > all feature tests there's this output: > > > > > > > > BUILD: Doing 'make -j12' parallel build > > > > config/Makefile:288: No libdw DWARF unwind found, Please install > > > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > > > > > > > Auto-detecting system features: > > > > ... dwarf: [ on ] > > > > ... glibc: [ on ] > > > > ... gtk2: [ on ] > > > > ... libaudit: [ on ] > > > > ... libbfd: [ on ] > > > > ... libelf: [ on ] > > > > ... libnuma: [ on ] > > > > ... libperl: [ on ] > > > > ... libpython: [ on ] > > > > ... libslang: [ on ] > > > > ... libunwind: [ on ] > > > > ... libdw-dwarf-unwind: [ OFF ] > > > > ... DWARF post unwind library: libunwind > > > > > > > > but: > > > > > > > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version > > > > > > > > Also, the information content of this line is unclear to me: > > > > > > > > ... DWARF post unwind library: libunwind > > > > > > > > > > > > what does that line want to tell? > > > > > > this tells what DWARF unwind library is compiled > > > in.. 'libunwind' in this case > > > > So my (stylistic) complaint is that it's really reading weird in a > > table generated with the following purpose: > > > > Auto-detecting system features: > > > > Also, we already know that libunwind is present, because just in the > > line before it, it says: > > > > ... libunwind: [ on ] > > > > So it's doubly confusing. How about not displaying that line at all? > > Is there a strong reason to not keep 'OFF' messages on a single line? > > well, on/OFF lines are only about detecting libs > > this line: > 'DWARF post unwind library: libunwind' > > is about telling which one goes in.. could be you have both > libraries detected and need to choose one or keep default Okay - but that is not at all clear from the output. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/