Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbaB0PL3 (ORCPT ); Thu, 27 Feb 2014 10:11:29 -0500 Received: from smtp0.epfl.ch ([128.178.224.218]:33477 "EHLO smtp0.epfl.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbaB0PL2 (ORCPT ); Thu, 27 Feb 2014 10:11:28 -0500 Message-ID: <530F5599.2060100@epfl.ch> Date: Thu, 27 Feb 2014 16:11:21 +0100 From: Florian Vaussard Reply-To: florian.vaussard@epfl.ch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Peter Ujfalusi , Lee Jones CC: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock References: <1393509410-1640-1-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1393509410-1640-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 02/27/2014 02:56 PM, Peter Ujfalusi wrote: > Hi, > > While looking into a report by Florian Vaussard [1] I have noticed couple of most > likely unrelated issues: > - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is set > to 100KHz as default. > - if I set the audpwron GPIO high [2] in the bootloader the i2c communication towards > twl6040 will be broken > > The solution or these are: > set the twl6040 to i2c fast mode with regmap patch > Clear the INTID register right after we request the audpwron GPIO and set it to > low. > > Generated on top of: > git://git.linaro.org/people/lee.jones/mfd.git for-mfd-next > > Tested on PandaBoard, PandaBoardES, OMAP4-blaze (SDP) > > [1] http://www.spinics.net/lists/arm-kernel/msg310725.html > [2] Command in u-boot to enable the audpwron on PandaBoards: gpio set 127 > > Regards, > Peter > --- > Peter Ujfalusi (3): > mfd: twl6040: Select i2c fast mode as default with regmap patch > mfd: twl6040: Move register patching earlier in probe > mfd: twl6040: Clear the interrupt ID register before requesting IRQ Patch 3 is making my system to boot normally. Now, it is hard to devise if this is the root cause of the problem that I was experiencing, since adding a sleep at the exact same place was fixing my issue. Your twl6040_reg_read() could have the same effect, without solving directly the issue. Anyway, I tested your series on DuoVero. Tested-by: Florian Vaussard Regards, Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/