Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589AbaB0Th4 (ORCPT ); Thu, 27 Feb 2014 14:37:56 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:51097 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750765AbaB0Thz convert rfc822-to-8bit (ORCPT ); Thu, 27 Feb 2014 14:37:55 -0500 Date: Thu, 27 Feb 2014 14:37:53 -0500 From: Steven Rostedt To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker , Ingo Molnar , josh@joshtriplett.org Subject: Re: [PATCH 25/46] kernel: Add prototype declaration to header file include/linux/ftrace.h Message-ID: <20140227143753.42451556@gandalf.local.home> In-Reply-To: References: <7b4a60c74ced00e0d65c38488f20dc4bd69f0dd2.1393493276.git.rashika.kheria@gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Feb 2014 17:32:47 +0530 Rashika Kheria wrote: > Add prototype declaration of function to header file > include/linux/ftrace.h because it is used by more than one file. > > This eliminates the following warning in kernel/trace/ftrace.c: > kernel/trace/ftrace.c:4914:5: warning: no previous prototype for ‘ftrace_graph_entry_stub’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett > --- > include/linux/ftrace.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index 68ea184..da1c31f 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -672,6 +672,8 @@ struct ftrace_graph_ret { > typedef void (*trace_func_graph_ret_t)(struct ftrace_graph_ret *); /* return */ > typedef int (*trace_func_graph_ent_t)(struct ftrace_graph_ent *); /* entry */ > > +int ftrace_graph_entry_stub(struct ftrace_graph_ent *trace); This doesn't need to be in a header file as it is only called by assmebly. But I have no problems with it being in one, but it should have a comment stating this: /* This is only called by assembly code, declared here for consistency */ -- Steve > + > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > > /* for init task */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/