Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbaB0Vej (ORCPT ); Thu, 27 Feb 2014 16:34:39 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:55442 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbaB0Veg (ORCPT ); Thu, 27 Feb 2014 16:34:36 -0500 MIME-Version: 1.0 In-Reply-To: <20140226215452.GA11468@earth.universe> References: <1393375569-21751-1-git-send-email-sre@debian.org> <1393375569-21751-2-git-send-email-sre@debian.org> <20140226215452.GA11468@earth.universe> Date: Thu, 27 Feb 2014 22:34:35 +0100 Message-ID: Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer From: Belisko Marek To: Sebastian Reichel Cc: Dmitry Eremin-Solenikov , David Woodhouse , Jonathan Cameron , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , LKML , "devicetree@vger.kernel.org" , linux-iio@vger.kernel.org, =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, On Wed, Feb 26, 2014 at 10:54 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: >> [...] >> > + int val, err; >> > + err = iio_read_channel_average_raw(channel, &val); >> Where this function comes from? I cannot find it in current linux-next >> (only iio_read_channel_raw()). Am I missing some patches? Thx. > > Ah right. I planned to send a patch adding this function together > with the rx51-battery patchset, but it seems I forgot to include it. > > Sorry for the inconvenience. I will send it out as a separate patch > now. > >> BTW when I convert to iio consumer and use DT some of values work >> but some of them just report 0 :( (I don't have latest twl4030-madc >> iio patches). > > Can you retry with the twl4030-madc iio patch from today? The > older patchsets, which do not contain the "tested on real hw" > note are slightly broken. Well I've tried and it's worse :). I got during booting: [ 2.218383] ERROR: could not get IIO channel /battery:temp(0) [ 2.224639] platform battery.4: Driver twl4030_madc_battery requests probe deferral Not sure if it's just error or warning but temp is always reported as 0 (and also other values in sysfs). My patches ca be found here: https://patchwork.kernel.org/patch/3735981/ https://patchwork.kernel.org/patch/3735961/ https://patchwork.kernel.org/patch/3735941/ > > -- Sebastian BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/