Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752139AbaB0WsS (ORCPT ); Thu, 27 Feb 2014 17:48:18 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35766 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbaB0WsR (ORCPT ); Thu, 27 Feb 2014 17:48:17 -0500 Date: Thu, 27 Feb 2014 14:48:14 -0800 From: josh@joshtriplett.org To: Steven Rostedt Cc: Rashika Kheria , linux-kernel@vger.kernel.org, Frederic Weisbecker , Ingo Molnar Subject: Re: [PATCH 25/46] kernel: Add prototype declaration to header file include/linux/ftrace.h Message-ID: <20140227224814.GB30335@cloud> References: <7b4a60c74ced00e0d65c38488f20dc4bd69f0dd2.1393493276.git.rashika.kheria@gmail.com> <20140227143753.42451556@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140227143753.42451556@gandalf.local.home> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 27, 2014 at 02:37:53PM -0500, Steven Rostedt wrote: > On Thu, 27 Feb 2014 17:32:47 +0530 > Rashika Kheria wrote: > > > Add prototype declaration of function to header file > > include/linux/ftrace.h because it is used by more than one file. > > > > This eliminates the following warning in kernel/trace/ftrace.c: > > kernel/trace/ftrace.c:4914:5: warning: no previous prototype for ‘ftrace_graph_entry_stub’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > --- > > include/linux/ftrace.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index 68ea184..da1c31f 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -672,6 +672,8 @@ struct ftrace_graph_ret { > > typedef void (*trace_func_graph_ret_t)(struct ftrace_graph_ret *); /* return */ > > typedef int (*trace_func_graph_ent_t)(struct ftrace_graph_ent *); /* entry */ > > > > +int ftrace_graph_entry_stub(struct ftrace_graph_ent *trace); > > This doesn't need to be in a header file as it is only called by > assmebly. But I have no problems with it being in one, but it should > have a comment stating this: > > /* This is only called by assembly code, declared here for consistency */ That seems quite reasonable, yeah. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/