Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbaB0Xcp (ORCPT ); Thu, 27 Feb 2014 18:32:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40495 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbaB0Xco (ORCPT ); Thu, 27 Feb 2014 18:32:44 -0500 Date: Thu, 27 Feb 2014 15:32:42 -0800 From: Andrew Morton To: NeilBrown Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux RAID , "majianpeng" , lkml Subject: Re: [PATCH] md / procfs: avoid Oops if md-mod removed while /proc/mdstat is being polled. Message-Id: <20140227153242.42cb9b9ef83dacc895017d44@linux-foundation.org> In-Reply-To: <20140228100757.7dbd3dae@notabene.brown> References: <20140227172445.13644477@notabene.brown> <20140227125807.d034c50c7fe2e1a9f3c38ec1@linux-foundation.org> <20140228083443.64c92382@notabene.brown> <20140227135125.92a56ff656b3ca8d0b5d9029@linux-foundation.org> <20140228100757.7dbd3dae@notabene.brown> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Feb 2014 10:07:57 +1100 NeilBrown wrote: > On Thu, 27 Feb 2014 13:51:25 -0800 Andrew Morton > wrote: > > > On Fri, 28 Feb 2014 08:34:43 +1100 NeilBrown wrote: > > > > > On Thu, 27 Feb 2014 12:58:07 -0800 Andrew Morton > > > wrote: > > > > > > > On Thu, 27 Feb 2014 17:24:45 +1100 NeilBrown wrote: > > > > > > > > > If poll or select is waiting on /proc/mdstat when md-mod is unloaded > > > > > an oops will ensure when the poll/select completes. > > > > > > > > > > This is because the wait_queue_head which is registered with poll_wait() > > > > > is local to the module and no longer exists when the poll completes and > > > > > detaches that wait_queue_head (in poll_free_wait -> remove_wait_queue). > > > > > > > > > > To fix this we need the wait_queue_head to have (at least) the same life > > > > > time as the proc_dir_entry. So this patch places it in that structure. > > > > > > > > > > We: > > > > > - add pde_poll_wait to struct proc_dir_entry > > > > > - call poll_wait() passing this when poll() is called on the proc file > > > > > - export a function proc_wake_up which will call wake_up() on pde_poll_wait > > > > > > > > > > and make use of all that in md.c > > > > > > > > This sounds wrong. If a userspace process is waiting on > > > > md_event_waiters then the md module is "busy" and the rmmod attempt > > > > should fail? > > > > > > Al Viro says "no" quite firmly. > > > > > > I think the core argument is that > > > > > > rmmod md-mod < /proc/mdstat > > > > > > would deadlock. > > > > Well, only if the rmmod hangs around waiting for the module to go idle. > > I'm thinking rmmod should fail. EBUSY. This? What happens if we just fail the rmmod when the module is busy (which it is). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/