Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751164AbaB1F1P (ORCPT ); Fri, 28 Feb 2014 00:27:15 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:28406 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbaB1F1O (ORCPT ); Fri, 28 Feb 2014 00:27:14 -0500 Message-ID: <53101E1A.6020707@huawei.com> Date: Fri, 28 Feb 2014 13:26:50 +0800 From: Ding Tianhong User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: John Fastabend CC: Patrick McHardy , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net RESEND] vlan: don't allow to add VLAN on VLAN device References: <530FF7BF.4030706@huawei.com> <53100677.2060705@intel.com> In-Reply-To: <53100677.2060705@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.22.246] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014/2/28 11:45, John Fastabend wrote: > On 2/27/2014 6:43 PM, Ding Tianhong wrote: >> I run these steps: >> >> modprobe 8021q >> vconfig add eth2 20 >> vconfig add eth2.20 20 >> ifconfig eth2 xx.xx.xx.xx >> >> then the Call Trace happened: >> > > [...] > >> ======================================================================== >> >> The reason is that if add vlan on vlan dev, the vlan dev will create vlan_info, >> then the notification will let the real dev to run dev_set_rx_mode() and hold >> netif_addr_lock, and then the real dev will call ndo_set_rx_mode(), if the real >> dev is vlan dev, the ndo_set_rx_mode() will hold netif_addr_lock again, so deadlock >> happened. >> >> Don't allow to add vlan on vlan dev to fix this problem. >> >> Signed-off-by: Ding Tianhong >> --- > > I'm not sure we can just disable stacked vlans. There might be something > using them today and they have worked in the past. Lets try to find a > better fix. > > .John Yes, maybe I miss something, can you gave me a scene that the use of eth2.20.30? the device is created from vlan device eth2.20, than I will find a better way to fix it. Thanks Ding > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/