Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbaB1Hdp (ORCPT ); Fri, 28 Feb 2014 02:33:45 -0500 Received: from www84.your-server.de ([213.133.104.84]:41001 "EHLO www84.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbaB1Hdo (ORCPT ); Fri, 28 Feb 2014 02:33:44 -0500 Message-ID: <1393572804.1019.14.camel@wall-e.seibold.net> Subject: Re: [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso From: Stefani Seibold To: Andy Lutomirski Cc: X86 ML , "H. Peter Anvin" , Greg KH , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , Andi Kleen , Andrea Arcangeli , John Stultz , Pavel Emelyanov , Cyrill Gorcunov , andriy.shevchenko@linux.intel.com, Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com Date: Fri, 28 Feb 2014 08:33:24 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: stefani@seibold.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 27.02.2014, 16:18 -0800 schrieb Andy Lutomirski: > I'd still like someone else to confirm that the 32-bit vDSO is working > on all common configurations before I'm happy with it, but this should > be a considerable improvement. > > Someone who maintains the clock code should review the changes in: > > commit 0fc8a237cbe98a06962f5ea37d24fc2369e23c74 > Author: Stefani Seibold > Date: Wed Feb 19 10:09:10 2014 +0100 > > x86, vdso: Add 32-bit VDSO time support for the 64-bit kernel > > very carefully. > > There's still something extremely questionable about VDSO_PAGES in the > 32-bit vDSO code. It appears to be terminally screwed up, and AFAICS it > only works at all because none of the 32-bit vDSO images ever exceed > 4096 bytes. > The 4096 bytes limit was not introduced by the patch set. It is still there for compatibility reason. > Note: Patch 4 fixes a bug that's present even in -linus, so it might > make sense to send it to Linus more quickly than the rest of this > series. > > Changes from v1: > - Adjust CFLAGS instead of using asmlinkage. > - Add more fixes. > > Andy Lutomirski (4): > x86: Use the default ABI for the 32-bit vDSO > x86: Inline the CLOCK_MONOTONIC vdso code > x86: Patch alternatives in the 32-bit vDSO > x86: Zero-pad the VVAR page > > arch/x86/include/asm/vdso.h | 2 ++ > arch/x86/kernel/vmlinux.lds.S | 5 +++++ > arch/x86/vdso/Makefile | 2 +- > arch/x86/vdso/vclock_gettime.c | 2 +- > arch/x86/vdso/vdso32-setup.c | 25 +++++++++++++------------ > arch/x86/vdso/vma.c | 9 ++++++--- > 6 files changed, 28 insertions(+), 17 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/