Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbaB1Q0s (ORCPT ); Fri, 28 Feb 2014 11:26:48 -0500 Received: from smtp5.epfl.ch ([128.178.224.8]:52140 "EHLO smtp5.epfl.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbaB1QZ6 (ORCPT ); Fri, 28 Feb 2014 11:25:58 -0500 From: Florian Vaussard To: Andy Whitcroft , Joe Perches Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] checkpatch: fix spurious vendor compatible warnings Date: Fri, 28 Feb 2014 17:25:42 +0100 Message-Id: <1393604742-14317-3-git-send-email-florian.vaussard@epfl.ch> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1393604742-14317-1-git-send-email-florian.vaussard@epfl.ch> References: <1393604742-14317-1-git-send-email-florian.vaussard@epfl.ch> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With a compatible string like compatible = "foo"; checkpatch will currently try to find "foo" in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case. Skip the vendor test if the compatible is not like compatible = "vendor,something"; Signed-off-by: Florian Vaussard --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e304e77..7437505 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2058,6 +2058,7 @@ sub process { my $vendor = $compat; my $vendor_path = $dt_path . "vendor-prefixes.txt"; next if (! -f $vendor_path); + next if not $vendor =~ /^[a-zA-Z0-9\-]+\,.*/; $vendor =~ s/^([a-zA-Z0-9\-]+)\,.*/$1/; `grep -Eq "$vendor" $vendor_path`; if ( $? >> 8 ) { -- 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/