From: Andi Kleen <andi@firstfloor.org>
To: Don Zickus <dzickus@redhat.com>
Cc: acme@ghostprotocols.net, LKML <linux-kernel@vger.kernel.org>,
        jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
        eranian@google.com
Subject: Re: [PATCH 00/19 V2] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems
References: <1393609388-40489-1-git-send-email-dzickus@redhat.com>
Date: Fri, 28 Feb 2014 10:57:48 -0800
In-Reply-To: <1393609388-40489-1-git-send-email-dzickus@redhat.com> (Don
	Zickus's message of "Fri, 28 Feb 2014 12:42:49 -0500")
Message-ID: <87wqgfawur.fsf@tassilo.jf.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

Don Zickus <dzickus@redhat.com> writes:
>
> A handful of patches include re-enabling MMAP2 support and some fixes
> to perf itself.

I would suggest to pursue the lone kernel patch separately. Hopefully
that can be merged soon, once the remainin problems with that are 
addressed.

>
> Comemnts, feedback, anything else welcomed.

As a high level comment, can you add support for CSV mode? 
(-x, in other tools)

I assume most people would data mine the output in some form,
and that's much easier with a more machine oriented format.

Also you should probably have the standard perf conventions
for output fds (--log-fd, --output, default to stderr). otherwise
the output may often be lost.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/