Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbaB1Uvh (ORCPT ); Fri, 28 Feb 2014 15:51:37 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.228]:45856 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752130AbaB1Uvg (ORCPT ); Fri, 28 Feb 2014 15:51:36 -0500 Date: Fri, 28 Feb 2014 15:51:30 -0500 From: Steven Rostedt To: Peter Zijlstra Cc: "H. Peter Anvin" , Vince Weaver , Linux Kernel , Ingo Molnar , Jiri Olsa , Arnaldo Carvalho de Melo Subject: Re: [PATCH] x86: Rename copy_from_user_nmi() to copy_from_user_trace() Message-ID: <20140228155130.26adcef3@gandalf.local.home> In-Reply-To: <20140228204621.GA14089@laptop.programming.kicks-ass.net> References: <20140227215726.7018c861@gandalf.local.home> <20140228092341.12a40f7c@gandalf.local.home> <1c583986-74f8-4829-883b-390dc49ddabb@email.android.com> <20140228154026.GH9987@twins.programming.kicks-ass.net> <5310B60F.30806@zytor.com> <20140228112946.1f194397@gandalf.local.home> <20140228143316.211d4034@gandalf.local.home> <20140228204621.GA14089@laptop.programming.kicks-ass.net> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Feb 2014 21:46:21 +0100 Peter Zijlstra wrote: > On Fri, Feb 28, 2014 at 02:33:16PM -0500, Steven Rostedt wrote: > > [ H. Peter, Here's the rename patch. I did not include your update. You > > can add that first and then massage this patch on top. But this isn't > > critical for mainline or stable, where as I believe your patch is. ] > > > > The tracing utilities sometimes need to read from userspace (stack tracing), > > and to do this it has as special copy_from_user function called > > copy_from_user_nmi(). Well, as tracers can call this from outside of > > nmi context, the "_nmi" part is a misnomer and "_trace" is a better > > name. > > NAK, spin_lock_irq() is very much an IRQ safe lock. Similarly > copy_from_user_nmi() is an NMI safe copy from user. > > Furthermore, there's exactly 0 trace users, so the proposed name is > actively worse. Heh, I consider perf and oprofile special tracers ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/