Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbaDAEcq (ORCPT ); Tue, 1 Apr 2014 00:32:46 -0400 Received: from mail-oa0-f53.google.com ([209.85.219.53]:61714 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbaDAEco (ORCPT ); Tue, 1 Apr 2014 00:32:44 -0400 MIME-Version: 1.0 In-Reply-To: <7htxae5plh.fsf@paris.lan> References: <3fa0ea3a19a51ae2797a25e281763451ad8d2844.1395322529.git.viresh.kumar@linaro.org> <7htxae5plh.fsf@paris.lan> Date: Tue, 1 Apr 2014 10:02:43 +0530 Message-ID: Subject: Re: [RFC 2/4] timer: don't migrate pinned timers From: Viresh Kumar To: Kevin Hilman Cc: Thomas Gleixner , =?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?= , Peter Zijlstra , Ingo Molnar , Tejun Heo , Li Zefan , Lists linaro-kernel , Linux Kernel Mailing List , Cgroups Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31 March 2014 21:26, Kevin Hilman wrote: > Viresh Kumar writes: >> + if (is_pinned) { >> + pr_warn("%s: can't migrate pinned timer: %p, removing it\n", >> + __func__, timer); > > printk message will be confusing: removing it from what? Hmm.. So, I am looking to do two modifications here. Just need inputs if that would be the right thing to do: - do a WARN() here as these timers should have been already removed - change print to: "can't migrate pinned timer %p, deactivating timer" Looks fine? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/