Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbaDAJHJ (ORCPT ); Tue, 1 Apr 2014 05:07:09 -0400 Received: from www.linutronix.de ([62.245.132.108]:41920 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbaDAJHF (ORCPT ); Tue, 1 Apr 2014 05:07:05 -0400 Date: Tue, 1 Apr 2014 11:07:14 +0200 (CEST) From: Thomas Gleixner To: Marc Kleine-Budde cc: LKML , Wolfgang Grandegger , Markus Pargmann , Benedikt Spranger , linux-can@vger.kernel.org, netdev@vger.kernel.org, David Miller Subject: Re: [patch 00/12] can: c_can: Fix a series of serious bugs and improve the performance In-Reply-To: <533A742F.4090703@pengutronix.de> Message-ID: References: <20140318171007.528610837@linutronix.de> <533A742F.4090703@pengutronix.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Apr 2014, Marc Kleine-Budde wrote: > On 04/01/2014 12:35 AM, Thomas Gleixner wrote: > > Dear Maintainers, > > > > On Tue, 18 Mar 2014, Thomas Gleixner wrote: > >> The driver is full of serious bugs: > >> > >> - Two HW init routines are not spec compliant. > >> > >> - Completely defective message buffer handling in several ways > >> That leads to interrupt storms and complete lockups. > >> > >> - Complete lack of SMP awareness > >> > >> What's amazing is that people "optimize" and "fix" the driver over and > >> over, but nobody bothered to understand the manual and repair the code > >> for real. > >> > >> The series fixes _ALL_ bugs which I found so far, but I'm sure there > >> are more issues burried in that unreadable mess. I'm just not able to > >> trigger them. > > > > What's the state of this series? > > I'll apply your patches today. Thanks! Please drop the last one which was not part of the series: Subject: can: c_can: Reduce interrupt load by 50% While it works like a charm, we've seen an odd case were TX started to stall. Had not yet time to dig into that. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/