Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbaDAJ73 (ORCPT ); Tue, 1 Apr 2014 05:59:29 -0400 Received: from mail-yh0-f54.google.com ([209.85.213.54]:48782 "EHLO mail-yh0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbaDAJ71 (ORCPT ); Tue, 1 Apr 2014 05:59:27 -0400 MIME-Version: 1.0 In-Reply-To: References: <532FE3B2.9060808@biereigel-wb.de> <533014B1.4030307@biereigel-wb.de> <5331E5EB.5000304@biereigel-wb.de> <5331E9E4.4050201@gmail.com> <5332099B.8090305@gmail.com> <5332AF10.90109@biereigel.de> From: Kieran Clancy Date: Tue, 1 Apr 2014 20:23:03 +1030 Message-ID: Subject: Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not "open" after suspend to RAM. To: "D. G. Jansen" Cc: Stefan Biereigel , Juan Manuel Cabo , Stefan Biereigel , Lan Tianyu , "linux-acpi@vger.kernel.org" , "linux-kernel@vger kernel org" , Len Brown , "Rafael J. Wysocki" , San Zamoyski , "D. Jansen" , "Maurizio D'Addona" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 29, 2014 at 1:51 AM, D. G. Jansen wrote: > > This patch (processing events) works for me on Samsung 535. Hi Dennis and others, Thank you for testing. I have also been testing this patch for a couple of days, and have not encountered any problems. I have now submitted a request for testing on the kernel bugzilla entry for the bug fixed by the earlier patch in question: https://bugzilla.kernel.org/show_bug.cgi?id=44161#c173 The CC list has 62 users, so hopefully we will get some more testers. The comment I posted is repeated below: -------------- Created attachment 131151 [details] process rather than discard events in acpi_ec_clear Hi all, If you have a machine that was (previously) affected by this bug, could you please take the time to try a new patch for this issue? A user with an older Samsung machine found that the earlier patch introduced some issues for them, so this is a new patch designed to be a better solution to the problem. Currently the new patch has only been tested on 2 affected machines (to my knowledge), so I would be very grateful if anyone else can test this patch (especially users with Samsung series 5 or 7 machines). You will need to use a recent kernel source like 3. (one which includes the earlier acpi_ec_clear patch), or otherwise apply the previous patch first: https://github.com/torvalds/linux/commit/ad332c8a45330d170bb38b95209de449b31cd1b4.patch Then apply the attachment ec_process_stale_events.patch Please test to see if your lid closing / suspending / etc. still work as intended with this patch. This new patch also provides some debug information after every resume/boot which will show up in dmesg something like: [ 1192.208056] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.217844] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.218844] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.222835] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.223834] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.224833] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.227833] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.228834] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.229832] ACPI : EC: acpi_ec_clear: EC_SC 0x28 [ 1192.230828] ACPI : EC: 8 stale EC events cleared Please report if you get any EC_SC bytes here _other than_ 0x28. I only get 0x28 on my machine but I am very interested to know if other affected machines produce something else. If you test it, please also report your system's product code, e.g.: # dmidecode -s system-product-name 900X3F # dmidecode -s baseboard-product-name NP900X3F-K01AU Many thanks, Kieran -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/