To: linux-kernel@vger.kernel.org
From: Duncan <1i5t5.duncan@cox.net>
Subject: Re: [PATCH v2] lib: add size unit t/p/e to memparse
Date: Tue, 1 Apr 2014 10:55:59 +0000 (UTC)
Lines: 19
Message-ID: <pan$8fddd$cc4f106$67b55dbb$abaf55ec@cox.net>
References: <1396346251-2506-1-git-send-email-guihc.fnst@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
User-Agent: Pan/0.140 (Chocolate Salty Balls; GIT 2ae6aff
 /usr/src/portage/src/egit-src/pan2)
Cc: linux-btrfs@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org

Gui Hecheng posted on Tue, 01 Apr 2014 17:57:31 +0800 as excerpted:

> + *	potentially suffixed with 
> + *	%K (for kibibytes, or 1024 bytes),
> + *	%M (for mebibytes, or 1048576 bytes),
> + *	%G (for gibibytes, or 1073741824),
> + *	%T (for tebibytes, or 1099511627776),
> + *	%P (for pebibytes, or 1125899906842624 bytes),
> + *	%E (for exbibytes, or 1152921504606846976 bytes).

Why do the first two and the last two end in bytes, but the the middle 
two don't?  I'd suggest either only specifying bytes on the first one
(a reasonably common pattern in English, with the carry down to the 
others implied) or on all of them.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/