Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757432AbaDBGLV (ORCPT ); Wed, 2 Apr 2014 02:11:21 -0400 Received: from relay.parallels.com ([195.214.232.42]:44962 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756703AbaDBGLU (ORCPT ); Wed, 2 Apr 2014 02:11:20 -0400 Message-ID: <533BAA03.9000406@parallels.com> Date: Wed, 2 Apr 2014 10:11:15 +0400 From: Vladimir Davydov MIME-Version: 1.0 To: Greg Thelen CC: , , , , , , Subject: Re: [PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG References: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.30.16.96] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2014 04:48 AM, Greg Thelen wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 3dd389aa91c7..6d6959292e00 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -358,17 +358,6 @@ kmem_cache_alloc_node_trace(struct kmem_cache *s, > #include > #endif > > -static __always_inline void * > -kmalloc_order(size_t size, gfp_t flags, unsigned int order) > -{ > - void *ret; > - > - flags |= (__GFP_COMP | __GFP_KMEMCG); > - ret = (void *) __get_free_pages(flags, order); > - kmemleak_alloc(ret, size, 1, flags); > - return ret; > -} > - > Removing this from the header file breaks builds without > CONFIG_TRACING. > Example: > % make allnoconfig && make -j4 mm/ > [...] > include/linux/slab.h: In function ‘kmalloc_order_trace’: > include/linux/slab.h:367:2: error: implicit declaration of function ‘kmalloc_order’ [-Werror=implicit-function-declaration] Oh, my bad - forgot to add the function declaration :-( The fixed version is on its way. Thank you for catching this! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/