Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758016AbaDBHOy (ORCPT ); Wed, 2 Apr 2014 03:14:54 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:47903 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757989AbaDBHOw (ORCPT ); Wed, 2 Apr 2014 03:14:52 -0400 Date: Wed, 2 Apr 2014 09:14:45 +0200 From: Martin Schwidefsky To: Linus Torvalds Cc: Ingo Molnar , linux-kernel , linux-s390 , Heiko Carstens Subject: Re: [GIT PULL] s390 patches for the 3.15 merge window Message-ID: <20140402091445.65c6b660@mschwide> In-Reply-To: References: <20140331092400.17071766@mschwide> <20140401085218.72f67e51@mschwide> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14040207-6892-0000-0000-000008538B21 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Apr 2014 08:40:41 -0700 (PDT) Linus Torvalds wrote: > > > On Tue, 1 Apr 2014, Martin Schwidefsky wrote: > > > > I gave up after a few hours trying to solve the header dependencies, the two > > trouble makes are alpha with the task_thread_info call in mmu_context.h and > > arm with the preempt_enable_no_resched call. Welcome to include file hell. > > I don't understand. The only file should need is > . Maybe . > > Look at mm/mmu_context.c, for example. It includes > without having included very many header files at all. So we *know* that > that small set is sufficient. > > And there aren't very many users of and none of them > are other header files, so there's no point in trying to religiously avoid > including one or two header files from it. > > So I'm thinking something like this should work. It's untested, and maybe > some architecture really needs some other header file, but it looks quite > likely to work. No? I had a patch quite similar to yours and I ended up with the error report from the kbuild robot. Just tried yours with the corgi_defconfig and got this: In file included from include/linux/mmu_context.h:6, from drivers/usb/gadget/inode.c:27: /home4/mschwide/linux/arch/arm/include/asm/mmu_context.h: In function 'finish_arch_post_lock_switch': /home4/mschwide/linux/arch/arm/include/asm/mmu_context.h:82: error: implicit declaration of function 'preempt_enable_no_resched' Part of the problem is this lovely piece from include/linux/preempt.h: #ifdef MODULE /* * Modules have no business playing preemption tricks. */ #undef sched_preempt_enable_no_resched #undef preempt_enable_no_resched #undef preempt_enable_no_resched_notrace #undef preempt_check_resched #endif -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/