Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758361AbaDBJuw (ORCPT ); Wed, 2 Apr 2014 05:50:52 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:56165 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758164AbaDBJuu (ORCPT ); Wed, 2 Apr 2014 05:50:50 -0400 MIME-Version: 1.0 In-Reply-To: References: <1671118.MbmRfxWPeo@daeseok-laptop.cloud.net> <20140402091334.GV6991@mwanda> Date: Wed, 2 Apr 2014 18:50:49 +0900 Message-ID: Subject: Re: [PATCH] staging: lirc: fix NULL pointer dereference From: DaeSeok Youn To: m.chehab@samsung.com Cc: Dan Carpenter , devel , Andreea Bernat , Greg KH , jarod@wilsonet.com, linux-kernel , Paul McKenney , Martina Trompouki , linux-media@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please drop this patch. I made a patch as Dan's comment and sent it. Thanks. Daeseok Youn. 2014-04-02 18:41 GMT+09:00 DaeSeok Youn : > You are right. remove whole thing and send it again. > > Thanks. > Daeseok Youn > > 2014-04-02 18:13 GMT+09:00 Dan Carpenter : >> On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote: >>> >>> coccicheck says: >>> drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: >>> ERROR: ir is NULL but dereferenced. >>> >>> Signed-off-by: Daeseok Youn >>> --- >>> drivers/staging/media/lirc/lirc_igorplugusb.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c >>> index f508a13..0ef393b 100644 >>> --- a/drivers/staging/media/lirc/lirc_igorplugusb.c >>> +++ b/drivers/staging/media/lirc/lirc_igorplugusb.c >>> @@ -223,8 +223,8 @@ static int unregister_from_lirc(struct igorplug *ir) >>> int devnum; >>> >>> if (!ir) { >>> - dev_err(&ir->usbdev->dev, >>> - "%s: called with NULL device struct!\n", __func__); >>> + printk(DRIVER_NAME "%s: called with NULL device struct!\n", >>> + __func__); >> >> >> It should be pr_err() or something. But actually "ir" can't be NULL so >> just delete the whole condition. >> >> >>> return -EINVAL; >>> } >> >> regards, >> dan carpenter >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/