Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758450AbaDBLKl (ORCPT ); Wed, 2 Apr 2014 07:10:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58682 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758057AbaDBLKj (ORCPT ); Wed, 2 Apr 2014 07:10:39 -0400 Date: Wed, 2 Apr 2014 04:10:32 -0700 From: Christoph Hellwig To: Richard Hansen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Greg Troxel Subject: Re: [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC Message-ID: <20140402111032.GA27551@infradead.org> References: <533B04A9.6090405@bbn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533B04A9.6090405@bbn.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 01, 2014 at 02:25:45PM -0400, Richard Hansen wrote: > For the flags parameter, POSIX says "Either MS_ASYNC or MS_SYNC shall > be specified, but not both." [1] There was already a test for the > "both" condition. Add a test to ensure that the caller specified one > of the flags; fail with EINVAL if neither are specified. This breaks various (sloppy) existing userspace for no gain. NAK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/