Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758828AbaDBNjN (ORCPT ); Wed, 2 Apr 2014 09:39:13 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:41540 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758804AbaDBNjL convert rfc822-to-8bit (ORCPT ); Wed, 2 Apr 2014 09:39:11 -0400 Date: Wed, 2 Apr 2014 15:38:55 +0200 From: Eric =?UTF-8?B?QsOpbmFyZA==?= To: Shawn Guo Cc: CHAUMETTE Hubert , , , , Subject: Re: [PATCH] ARM: i.MX6: update KSZ9031 phy fixup Message-ID: <20140402153855.237e7a50@e6520eb> In-Reply-To: <20140402131404.GE8558@dragon> References: <1395421687-12934-1-git-send-email-hchaumette@adeneo-embedded.com> <20140321222320.14370739@e6520eb> <1762157698.5689069.1395675049240.JavaMail.zimbra@adeneo-embedded.com> <20140324164141.51b85f8c@e6520eb> <20140402131404.GE8558@dragon> Organization: =?UTF-8?B?RXVrcsOpYQ==?= Electromatique X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Le Wed, 2 Apr 2014 21:14:08 +0800, Shawn Guo a écrit : > > On Mon, Mar 24, 2014 at 04:41:41PM +0100, Eric Bénard wrote: > > Hi Hubert, > > > > Le Mon, 24 Mar 2014 16:30:49 +0100 (CET), > > CHAUMETTE Hubert a écrit : > > > > From: "Eric Bénard" > > > > that's board specific (the needed delay depends on the routing delay on > > > > the PCB), so this should not go in a generic file. > > > > > > > > Eric > > > > > > > > > > I admit it may need to be in a separate function, but this file already contains > > > board-specific fixups (for imx6q sabrelite, Data Modul eDM-QMX6). > > > > > true but that's not a reason to add more ;-) > > > > > Anyway, do you have any suggestion for the location I should put it ? > > > > > no idea at the moment, I simply used your patch to bring this issue on > > the ML as we recently needed to patch the default values for testing > > mainline kernel on a custom boards. > > Hmm, can such board-specific fixups be pushed down to bootloader? > that won't work if the kernel reset the PHY. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/