Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbaDBRxp (ORCPT ); Wed, 2 Apr 2014 13:53:45 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54577 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932541AbaDBRxo (ORCPT ); Wed, 2 Apr 2014 13:53:44 -0400 Message-ID: <533C4E8F.20306@ti.com> Date: Wed, 2 Apr 2014 13:53:19 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: , Greg KH CC: Grygorii Strashko , Kishon Vijay Abraham I , , , Subject: Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY References: <1394709073-1980-1-git-send-email-grygorii.strashko@ti.com> <20140313152024.GF4599@saruman.home> <20140313214450.GG27355@saruman.home> In-Reply-To: <20140313214450.GG27355@saruman.home> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: >> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: >>> This fixes a regression on Keystone 2 platforms caused by patch >>> 57303488cd37da58263e842de134dc65f7c626d5 >>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >>> optional support of generic phy in DWC3 core. >>> >>> On Keystone 2 platforms the USB is not working now because >>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >>> return -ENOSYS always. The log shows: >>> dwc3 2690000.dwc3: failed to initialize core >>> dwc3: probe of 2690000.dwc3 failed with error -38 >>> >>> Hence, fix it by making NULL a valid phy reference in Generic PHY >>> APIs stubs in the same way as it was done by the patch >>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >>> a valid phy reference". >>> >>> CC: Kishon Vijay Abraham I >>> CC: Felipe Balbi >>> CC: Santosh Shilimkar >>> Signed-off-by: Grygorii Strashko >> >> nice :-) >> >> Acked-by: Felipe Balbi > > Greg, if your tree isn't closed yet, could you consider this patch still > for v3.15 merge window ? Grygorii found a regression on Keystone > platforms which this patch fixes. Let me know if you need the original > patch and myself or Kishon can send it to you. > Just checking whether the fix was picked up for the 3.14 merge window ? Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/