Message-ID: <1396462368.20325.26.camel@dhcp-9-2-203-236.watson.ibm.com>
Subject: Re: [PATCH] integrity: get comm using lock to avoid race in string
 printing
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: Richard Guy Briggs <rgb@redhat.com>, linux-audit@redhat.com,
        linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org,
        eparis@redhat.com
Date: Wed, 02 Apr 2014 14:12:48 -0400
In-Reply-To: <6292885.20TorKeRiK@x2>
References: <11db0d126ef0ec7506ef5cb6f2f21c926d206436.1396455228.git.rgb@redhat.com>
	 <1396460387.20325.22.camel@dhcp-9-2-203-236.watson.ibm.com>
	 <6292885.20TorKeRiK@x2>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: 
> Hello Mimi,
> 
> On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote:
> > This change is already being upstreamed as commit 73a6b44 "Integrity:
> > Pass commname via get_task_comm()".
> 
> While I was looking at Richard's patch, I noticed a few places where cause and 
> op are logged and the string isn't tied together with a _ or -. These are in 
> ima/ima_appraise.c line 383, and ima/ima_policy.c lines 333, 657, and 683. Are 
> these fixed upstream? Or should a patch be made?

Nothing has changed in terms of 'cause' and 'op'.  I would suggest
making the changes in integrity_audit.c: integrity_audit_msg().

thanks,

Mimi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/