Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933192AbaDBUZI (ORCPT ); Wed, 2 Apr 2014 16:25:08 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:51396 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993AbaDBUZE (ORCPT ); Wed, 2 Apr 2014 16:25:04 -0400 Message-ID: <533C721E.1080004@gmail.com> Date: Wed, 02 Apr 2014 22:25:02 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 To: Florian Fainelli , Alexander Holler CC: "linux-kernel@vger.kernel.org" , netdev , Michal Simek , stable Subject: Re: [PATCH regression] net: phy: fix initialization (config_init) for Marvel 88E1116R PHYs References: <1396396559-6971-1-git-send-email-holler@ahsoftware.de> <533BD3CD.1010905@ahsoftware.de> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2014 09:01 PM, Florian Fainelli wrote: > 2014-04-02 2:09 GMT-07:00 Alexander Holler : >> Am 02.04.2014 02:57, schrieb Florian Fainelli: >>> 2014-04-01 16:55 GMT-07:00 Alexander Holler : >>>> Commit 7cd1463664c2a15721ff4ccfb61d4d970815cb3d (introduced with 3.14) >>>> changed the initialization of the mv643xx_eth driver to use phy_init_hw() >>>> to reset the PHY. Unfortunately the initialization for the 88E1116R PHY >>>> was broken such, that it used mdelay() instead of really waiting for a >>>> reset to finish. > > Can you resubmit with the following information: > > - you specify the commit that introduce the problem in parenthesis, > e.g: deadbeef ("dead: beef: cafe babe") > - put this dmesg snippet in your log message to clearly illustrate > what is happening > - clarify that the PHY needs to be polled in a comment in > m88e1116r_config_init() > > Meanwhile, it would be good if someone with access to this particular > PHY datasheet could look for known erratas, problems, non-standard > compliant behavior .... Alexander, I tried todays linux/master on Seagate Dockstar with Marvell 88E1116R (0x01410e40) and cannot reproduce any regression. I tried booting from tftp and usb, I also rebooted twice to see if there are any side effects - nothing - ethernet always comes up as expected. I am curious, how you determined above commit to be the cause of the regression you are seeing. Can you bisect, if you didn't already? Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/