Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbaDCJck (ORCPT ); Thu, 3 Apr 2014 05:32:40 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:35716 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbaDCJcf (ORCPT ); Thu, 3 Apr 2014 05:32:35 -0400 Date: Thu, 3 Apr 2014 11:32:30 +0200 From: Daniel Vetter To: Randy Dunlap Cc: Jani Nikula , Stephen Rothwell , Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix command parser debug print format mismatches Message-ID: <20140403093230.GB7225@phenom.ffwll.local> Mail-Followup-To: Randy Dunlap , Jani Nikula , Stephen Rothwell , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org References: <533B106B.8090408@infradead.org> <1396427060-12539-1-git-send-email-jani.nikula@intel.com> <533C2C1F.5010303@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533C2C1F.5010303@infradead.org> X-Operating-System: Linux phenom 3.14.0+ User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 02, 2014 at 08:26:23AM -0700, Randy Dunlap wrote: > On 04/02/2014 01:24 AM, Jani Nikula wrote: > > Drop the cast from the pointer diff to fix: > > > > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format '%td' expects > > argument of type 'ptrdiff_t', but argument 5 has type 'long unsigned int' > > [-Wformat] > > > > While at it, use %u for u32. > > > > Reported-by: Randy Dunlap > > Signed-off-by: Jani Nikula > > > > --- > > > > Randy, try as I might, I wasn't able to coerce gcc to spit out that > > warning. Please enlighten me! (Does this fix the warn?) > > Yes, it does. Thanks. > > Acked-by: Randy Dunlap Maybe I'm blind, but I think the recent refactoring patch fixed this. Can someone please double-check? I always get confused with printf formats ;-) Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/