Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751732AbaDCKnT (ORCPT ); Thu, 3 Apr 2014 06:43:19 -0400 Received: from 8bytes.org ([85.214.48.195]:44421 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbaDCKnN (ORCPT ); Thu, 3 Apr 2014 06:43:13 -0400 Date: Thu, 3 Apr 2014 12:43:08 +0200 From: Joerg Roedel To: Linus Torvalds Cc: Jiri Kosina , Andrew Morton , Mateusz Guzik , Greg Kroah-Hartman , Steven Rostedt , LKML , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov , Ingo Molnar , Mel Gorman , Kay Sievers Subject: Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline Message-ID: <20140403104308.GP13491@8bytes.org> References: <20140402144219.4cafbe37@gandalf.local.home> <20140402221212.GD16570@mguzik.redhat.com> <20140402162839.d3c00e9845e89d0f092c2ce3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Thu Apr 3 12:43:11 2014 X-DSPAM-Confidence: 0.9995 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 533d3b3f20861768916966 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 02, 2014 at 06:47:57PM -0700, Linus Torvalds wrote: > Whether it actually fixes the problem that Borislav had is > questionable, of course. For all I know, systemd debug mode generates > so much data in *other* ways and then causes feedback loops with the > kernel debugging that this patch is totally immaterial, and dmesg was > never the main issue. But unlike the "hide 'debug' from > /proc/cmdline", I think this patch at least _conceptually_ makes a lot > of sense, even if systemd gets fixed, so ... How about just ignoring writes to /dev/kmsg altogether by default (unless explicitly enabled in Kconfig or on the kernel cmdline)? Maybe I am missing something but what are the legitimate use-cases for generally allowing user-space to write into the kernel-log? Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/