Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753133AbaDCQdl (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Apr 2014 12:33:41 -0400
Received: from qmta09.emeryville.ca.mail.comcast.net ([76.96.30.96]:36097 "EHLO
	qmta09.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753049AbaDCQdS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Apr 2014 12:33:18 -0400
Date: Thu, 3 Apr 2014 11:33:15 -0500 (CDT)
From: Christoph Lameter <cl@linux.com>
X-X-Sender: cl@nuc
To: Joe Perches <joe@perches.com>
cc: Mitchel Humpherys <mitchelh@codeaurora.org>,
        Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: convert some level-less printks to pr_*
In-Reply-To: <1396291441.21529.52.camel@joe-AO722>
Message-ID: <alpine.DEB.2.10.1404031132310.21658@nuc>
References: <1395942859-11611-1-git-send-email-mitchelh@codeaurora.org> <1395942859-11611-2-git-send-email-mitchelh@codeaurora.org> <alpine.DEB.2.10.1403311334060.3313@nuc> <1396291441.21529.52.camel@joe-AO722>
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 31 Mar 2014, Joe Perches wrote:

> On Mon, 2014-03-31 at 13:35 -0500, Christoph Lameter wrote:
> > On Thu, 27 Mar 2014, Mitchel Humpherys wrote:
> >
> > > diff --git a/mm/slub.c b/mm/slub.c
> []
> > > @@ -9,6 +9,8 @@
> > >   * (C) 2011 Linux Foundation, Christoph Lameter
> > >   */
> > >
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> >
> > This is implicitly used by some macros? If so then please define this
> > elsewhere. I do not see any use in slub.c of this one.
>
> Hi Christoph
>
> All the pr_<level> macros use it.
>
> from include/linux/printk.h:

Ok then why do you add the definition to slub.c?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/