Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156AbaDCRmm (ORCPT ); Thu, 3 Apr 2014 13:42:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32213 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbaDCRmj (ORCPT ); Thu, 3 Apr 2014 13:42:39 -0400 Date: Thu, 3 Apr 2014 20:42:08 +0300 From: Dan Carpenter To: Jimmy Li Cc: Joe Perches , Greg Kroah-Hartman , Teodora Baluta , Peter P Waskiewicz Jr , Michael Gunselmann , Lisa Nguyen , Martin Hofmann , Malcolm Priestley , =?us-ascii?Q?=3D=3Futf-8=3FB=3FVMO8bGluIMSwemVy=3F=3D?= , Archana kumari , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning Message-ID: <20140403174208.GM6991@mwanda> References: <20140403163229.GA21383@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140403163229.GA21383@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 04, 2014 at 12:32:29AM +0800, Jimmy Li wrote: > Signed-off-by: Jimmy Li You dropped the commit message which said which sparse warnings were fixed. It should say something about the other cleanups as well. Also the subject prefix isn't right. Use: [PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning Or something. "drivers/" doesn't add any information. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/