Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753704AbaDCUCt (ORCPT ); Thu, 3 Apr 2014 16:02:49 -0400 Received: from mail-ve0-f173.google.com ([209.85.128.173]:57025 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753498AbaDCUCq (ORCPT ); Thu, 3 Apr 2014 16:02:46 -0400 MIME-Version: 1.0 In-Reply-To: <20140403194335.GC2472@mtj.dyndns.org> References: <20140403164911.GE24119@htj.dyndns.org> <20140403194335.GC2472@mtj.dyndns.org> Date: Thu, 3 Apr 2014 13:02:45 -0700 X-Google-Sender-Auth: xJ0esLxCJM4GXNp0UxXE1wzQj3w Message-ID: Subject: Re: [GIT PULL] cgroup changes for v3.15-rc1 From: Linus Torvalds To: Tejun Heo Cc: "Eric W. Biederman" , David Miller , Linux Kernel Mailing List , Li Zefan , Linux Containers , cgroups@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 3, 2014 at 12:43 PM, Tejun Heo wrote: > > Ah, I remembered the other way around. We could leak cgroup_root > reference, not the other way around. cgroup_mount() can be called > multiple times for the same sb and we inc cgroup_root's ref each time > but cgroup_kill_sb() only happens when the sb is released, so if we do > the following, Oh, Christ, I see what you are talking about. That interface is all kinds of crazy. > The cgroup_root should be destroyed but it isn't, I think. We'd need > to bump cgroup_root's refcnt only when a new sb is created. It's > kinda ugly. Hmmm... Ok, so I guess we can use that "new_sb_created" thing, and I'll redo my merge resolution to reflect that. I do find this incredibly ugly. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/