Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753581AbaDCUjo (ORCPT ); Thu, 3 Apr 2014 16:39:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:60821 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753497AbaDCUjk (ORCPT ); Thu, 3 Apr 2014 16:39:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,790,1389772800"; d="scan'208";a="514360593" Message-ID: <533DC6EF.9010909@linux.intel.com> Date: Thu, 03 Apr 2014 13:39:11 -0700 From: Srinivas Pandruvada User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Stephen Chandler Paul , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org CC: Benjamin Tissoires , Srinivas Pandruvada , Adam Williamson Subject: Re: [PATCH] Add sensor hub quirk for ThinkPad Helix References: <1396556875-31108-1-git-send-email-thatslyude@gmail.com> In-Reply-To: <1396556875-31108-1-git-send-email-thatslyude@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2014 01:27 PM, Stephen Chandler Paul wrote: > Just like some of the other laptops/tablets on the market with ultrabook > sensors, the ThinkPad Helix's sensor hub requires a special quirk in > order for it to power on properly. Without it the sensors are detected > by the kernel and set up as usual, but they won't output any data. This > will also fix the sensors on any other laptops with the same model of > sensor hub. > > Signed-off-by: Stephen Chandler Paul > --- > drivers/hid/hid-ids.h | 3 ++- > drivers/hid/hid-sensor-hub.c | 7 +++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index bd22126..3312f1b5 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -455,7 +455,8 @@ > > #define USB_VENDOR_ID_INTEL_0 0x8086 > #define USB_VENDOR_ID_INTEL_1 0x8087 > -#define USB_DEVICE_ID_INTEL_HID_SENSOR 0x09fa > +#define USB_DEVICE_ID_INTEL_HID_SENSOR_0 0x09fa > +#define USB_DEVICE_ID_INTEL_HID_SENSOR_1 0x0a04 > > #define USB_VENDOR_ID_STM_0 0x0483 > #define USB_DEVICE_ID_STM_HID_SENSOR 0x91d1 > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index 5182031..af8244b 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -697,10 +697,13 @@ static void sensor_hub_remove(struct hid_device *hdev) > > static const struct hid_device_id sensor_hub_devices[] = { > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_0, > - USB_DEVICE_ID_INTEL_HID_SENSOR), > + USB_DEVICE_ID_INTEL_HID_SENSOR_0), > .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1, > - USB_DEVICE_ID_INTEL_HID_SENSOR), > + USB_DEVICE_ID_INTEL_HID_SENSOR_0), > + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1, > + USB_DEVICE_ID_INTEL_HID_SENSOR_1), > .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_STM_0, > USB_DEVICE_ID_STM_HID_SENSOR), Acked-by: Srinivas Pandruvada Thanks, Srinivas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/