Date: Thu, 3 Apr 2014 23:03:00 +0200
From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Igor Mammedov <imammedo@redhat.com>, Andi Kleen <andi@firstfloor.org>,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, bp@suse.de,
        paul.gortmaker@windriver.com, JBeulich@suse.com, prarit@redhat.com,
        drjones@redhat.com, toshi.kani@hp.com, riel@redhat.com,
        gong.chen@linux.intel.com
Subject: Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary
 CPU with infinite wait loop
Message-ID: <20140403210300.GP22728@two.firstfloor.org>
References: <1396296565-19709-1-git-send-email-imammedo@redhat.com>
 <1396296565-19709-2-git-send-email-imammedo@redhat.com>
 <87ppkzk5zi.fsf@tassilo.jf.intel.com>
 <20140402232956.54848fbe@thinkpad>
 <20140403064337.GA29274@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140403064337.GA29274@gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Apr 03, 2014 at 08:43:37AM +0200, Ingo Molnar wrote:
> 
> * Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > > I've seen that. Kernel still boots. With your patch it would hang.
> 
> Nonsense, not booting is OK when critical hardware is genuinely bad - 
> this isn't a disk drive or networking where bad IO 'happens sometimes' 
> and failure is something we have to engineer for - this is the CPU!
> 
> If a critical piece of hardware like the CPU or RAM is non-functional 
> then it should be excluded by the user explicitly, not worked around 
> after some ugly, non-deterministic and fragile timeout.

That's generally not true. We try to recover as best as we can
and continue.

That's true for RCU stalls, and RAM errors (hwpoison) and
other error conditions. It's true for kernel problems
(we try to oops and continue, not to panic etc.)

Hanging forever is not recovering, it's just poor and broken 
error handling and generally not acceptable these days.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/