Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbaDDAxB (ORCPT ); Thu, 3 Apr 2014 20:53:01 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:58702 "EHLO mail-oa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbaDDAwz (ORCPT ); Thu, 3 Apr 2014 20:52:55 -0400 MIME-Version: 1.0 In-Reply-To: <20140403234850.GA13956@debian> References: <1396346657-7166-1-git-send-email-holler@ahsoftware.de> <533AFF77.5030106@codeaurora.org> <20140403234850.GA13956@debian> Date: Thu, 3 Apr 2014 17:52:55 -0700 X-Google-Sender-Auth: F7t0w2Kp0i_cPa-2A_9Mj6ayKdM Message-ID: Subject: Re: [PATCH] arm: don't allow CONFIG_DEBUG_SET_MODULE_RONX if CONFIG_JUMP_LABEL is enabled From: Kees Cook To: Rabin Vincent Cc: Laura Abbott , Alexander Holler , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon , LKML , Russell King Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 3, 2014 at 4:48 PM, Rabin Vincent wrote: > On Thu, Apr 03, 2014 at 04:14:54PM -0700, Kees Cook wrote: >> On Tue, Apr 1, 2014 at 4:08 PM, Rabin Vincent wrote: >> > Here's a patch (probably whitespace damaged, hence also attached) with >> > which dynamic ftrace works for me on top your other paches. Tested on >> > a non-LPAE SMP. >> >> Thanks! I'll incorporate calls to set_all_modules_text_rw/ro and see >> what I can make work. > > You can use the patch I posted yesterday for module support: > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/244558.html Yup, that's basically what I had too. So, even with your patch, I still get faults with ftrace. probe_kernel_write still errors for me, and I don't see why. I will send an updated patch series with my current CONFIG_DEBUG_RODATA work shortly... -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/