Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbaDDEuV (ORCPT ); Fri, 4 Apr 2014 00:50:21 -0400 Received: from ozlabs.org ([203.10.76.45]:49072 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbaDDEuS (ORCPT ); Fri, 4 Apr 2014 00:50:18 -0400 From: Rusty Russell To: Stefan Hajnoczi , "Theodore Ts'o" , Venkatesh Srinivas , Linux Kernel Developers List , "Michael S. Tsirkin" , Linux Virtualization Subject: Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor In-Reply-To: References: <1394841445-16142-1-git-send-email-venkateshs@google.com> <1394854471-25700-1-git-send-email-tytso@mit.edu> <87siqhu048.fsf@rustcorp.com.au> <20140317054053.GF14162@thunk.org> <871txysnw2.fsf@rustcorp.com.au> <87ha6fowh9.fsf@rustcorp.com.au> <20140401022708.GD4911@thunk.org> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Wed, 02 Apr 2014 18:06:08 +1030 Message-ID: <878urop4if.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan Hajnoczi writes: > On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o wrote: >> On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >>> >>> It's head of my virtio-next tree. >> >> Hey Rusty, >> >> While we have your attention --- what's your opinion about adding TRIM >> support to virtio-blk. I understand that you're starting an OASIS >> standardization process for virtio --- what does that mean vis-a-vis a >> patch to plumb discard support through virtio-blk? > > virtio-scsi already supports discard. But maybe you cannot switch > away from virtio-blk? > > If you need to add discard to virtio-blk then it could be added to the > standard. The standards text is kept in a svn repository here: > https://tools.oasis-open.org/version-control/browse/wsvn/virtio/ It would be trivial to add, and I wouldn't be completely opposed, but we generally point to virtio-scsi when people want actual features. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/