Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbaDDIYi (ORCPT ); Fri, 4 Apr 2014 04:24:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20411 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbaDDIYf (ORCPT ); Fri, 4 Apr 2014 04:24:35 -0400 Date: Fri, 4 Apr 2014 10:19:09 +0200 From: Stanislaw Gruszka To: Jakub =?utf-8?B?S2ljacWEc2tp?= Cc: Richard Genoud , Ivo van Doorn , Gertjan van Wingerde , Helmut Schaa , "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT Message-ID: <20140404081908.GB1448@redhat.com> References: <1396534327-12971-1-git-send-email-richard.genoud@gmail.com> <20140403173701.75c1f497@north> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140403173701.75c1f497@north> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 03, 2014 at 05:37:01PM +0200, Jakub KiciƄski wrote: > On Thu, 3 Apr 2014 16:12:07 +0200, Richard Genoud wrote: > > rt2x00usb_register_read_lock() calls rt2x00usb_vendor_req_buff_lock() > > that calls rt2x00usb_vendor_request() which is already looping up to > > REGISTER_BUSY_COUNT times. > > > > So this loop is not needed. > > Not true. rt2x00usb_vendor_request() busy-waits for usb_control_msg() > to succeed, rt2x00usb_register_read_lock() busy-waits for the register > field itself to become 0. Yeah, but still we are looping REGISTER_BUSY_COUNT*REGISTER_BUSY_COUNT what seems to be far too long. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/